Implement LSP didSave notification and rename request #48615
Conversation
|
Is this no longer relevant? |
|
It still is, sorry. Got a bit zealous with branch cleaning. |
| @@ -310,6 +310,7 @@ class ScriptLanguage { | |||
| Ref<Script> script; | |||
| String class_name; | |||
| String class_member; | |||
| String class_path; | |||
There was a problem hiding this comment.
Is it intended that the master branch has this addition but the matching 3.x PR didn't seem to need it? #48616
That's the only reason I hadn't merged this yet as I was waiting for @vnen to check it since changing a core struct that affects all language bindings increases the scope of this PR significantly. On the other hand I see that LookupResult only seems to be used by the GDScript editor so it's probably fine.
There was a problem hiding this comment.
Yes, the fundamentally there were different values between GDScript 2.0 and GDScript 1.0 that made accessing the base class for an extending class impossible in Godot 4.0, so I needed a way to reach it at the end of the day.
I made sure to only add a value, and changed nothing else about the code, so that it won't break any bindings that don't need it.
|
Thanks! |
This is a companion to #48616, but for 4.0. Fixes #47609. This implements the
textDocument/renamerequest for the language server to find symbols such as function names, variables, properties, signals and otherwise, and rename them wherever they match the original symbol.As a companion, this also adds the
textDocument/didSavenotification. This is because, by the time the text changes are received by the client, none of the variables have been renamed internally, which results in error. But saving the scripts will re-trigger a parsing of all changed scripts and thus find the new property names.Also fixes #50510 by reloading the script resource's internal state.